Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add security headers #276

Merged
merged 2 commits into from
Sep 11, 2023
Merged

✨ add security headers #276

merged 2 commits into from
Sep 11, 2023

Conversation

Brynjulf
Copy link
Contributor

@Brynjulf Brynjulf commented Sep 8, 2023 •
edited
Loading

Fixed a bug where we weren't using the nginx conf file

@Brynjulf Brynjulf changed the title feat: add security headers ✨ add security headers Sep 8, 2023
@Brynjulf Brynjulf force-pushed the feat/add-security-headers branch from 554a622 to c6788f4 Compare September 11, 2023 11:01
@Brynjulf Brynjulf marked this pull request as ready for review September 11, 2023 11:02
@Brynjulf Brynjulf requested a review from a team as a code owner September 11, 2023 11:02
mariush2
mariush2 requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@mariush2 mariush2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you also update the config/config_files/client.yaml to include a step in the compare action where it checks the remote/local securityheaders.conf file?

@Brynjulf Brynjulf requested a review from mariush2 September 11, 2023 11:09
@Brynjulf Brynjulf merged commit e50abe7 into main Sep 11, 2023
@Brynjulf Brynjulf deleted the feat/add-security-headers branch September 11, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariush2 mariush2 mariush2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brynjulf @mariush2