Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/use local storage keep alive #330

Merged
merged 6 commits into from
Nov 10, 2023
Merged

Feat/use local storage keep alive #330

merged 6 commits into from
Nov 10, 2023

Conversation

aslakihle
Copy link
Contributor

No description provided.

@aslakihle aslakihle marked this pull request as ready for review November 9, 2023 11:17
@aslakihle aslakihle requested a review from a team as a code owner November 9, 2023 11:17
mariush2
mariush2 reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@mariush2 mariush2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just add "ms" changes we talked about in frontend status👏🏻

@aslakihle aslakihle requested a review from mariush2 November 9, 2023 14:01
mariush2
mariush2 requested changes Nov 9, 2023
View reviewed changes
src/hooks/useLocalStorage.ts Outdated Show resolved Hide resolved
@aslakihle aslakihle requested a review from mariush2 November 10, 2023 07:42
@aslakihle aslakihle merged commit c1bbace into main Nov 10, 2023
@aslakihle aslakihle deleted the feat/useLocalStorageKeepAlive branch November 10, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariush2 mariush2 mariush2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aslakihle @mariush2