Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix darkmode bugs #808

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Fix darkmode bugs #808

merged 3 commits into from
Oct 18, 2024

Conversation

mariush2
Copy link
Contributor

@mariush2 mariush2 commented Oct 16, 2024 •
edited by azure-boards bot
Loading

  • Fixing Tabs.Tab dark color missing from EDS overrides
  • Fix hardcoded color in TopBarButton

AB#555433

@mariush2 mariush2 requested a review from a team as a code owner October 16, 2024 06:44
aslakihle
aslakihle previously approved these changes Oct 18, 2024
View reviewed changes
@mariush2
Merge remote-tracking branch 'origin/main' into fix/darkmode-certain-…
b438834 
…components

# Conflicts:
#	src/organisms/TopBar/TopBar.styles.ts
@mariush2 mariush2 merged commit 76036eb into main Oct 18, 2024
10 checks passed
@mariush2 mariush2 deleted the fix/darkmode-certain-components branch October 18, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslakihle aslakihle aslakihle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariush2 @aslakihle