Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix Select components calling onSubmit when users select items (with keyboard or mouse) #831

Merged
merged 1 commit into from
Oct 23, 2024
Merged

🐛 Fix Select components calling onSubmit when users select items (with keyboard or mouse) #831

merged 1 commit into from
Oct 23, 2024

Conversation

mariush2
Copy link
Contributor

@mariush2 mariush2 commented Oct 23, 2024 •
edited
Loading

Fixes #830

@mariush2 mariush2 requested a review from a team as a code owner October 23, 2024 06:18
@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 100% (🎯 100%) 11858 / 11858
🟢 Statements 100% (🎯 100%) 11858 / 11858
🟢 Functions 100% (🎯 100%) 547 / 547
🟢 Branches 100% (🎯 100%) 2459 / 2459
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/molecules/Select/SelectMenuItem.tsx 100% 100% 100% 100%
Generated in workflow #1071 for commit 7cca0a9 by the Vitest Coverage Report Action

@mariush2 mariush2 merged commit 6fc4515 into main Oct 23, 2024
10 checks passed
@mariush2 mariush2 deleted the fix/combobox-in-form branch October 23, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslakihle aslakihle aslakihle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ComboBox submitting form
2 participants
@mariush2 @aslakihle