Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install pybind11 from PyPI in CMake CI #3547

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Conversation

pinkwah
Copy link
Contributor

@pinkwah pinkwah commented Jun 20, 2022

Use pybind11 in the current virtualenv rather than getting it from
Conan.

This commit also bumps the CMake version to 3.19 due to the new
execute_process option COMMAND_ERROR_IS_FATAL LAST which will exit
early if pybind11 is not found.

Resolves: #3548

@pinkwah pinkwah self-assigned this Jun 20, 2022
@pinkwah pinkwah force-pushed the pypi-pybind branch 3 times, most recently from 009718a to 840a1d1 Compare June 20, 2022 12:47
Use pybind11 in the current virtualenv rather than getting it from
Conan.

This commit also bumps the CMake version to 3.19 due to the new
`execute_process` option `COMMAND_ERROR_IS_FATAL LAST` which will exit
early if pybind11 is not found.
@pinkwah pinkwah marked this pull request as ready for review June 20, 2022 13:24
@pinkwah pinkwah mentioned this pull request Jun 20, 2022
3 tasks
Copy link
Contributor

@dafeda dafeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@sondreso sondreso enabled auto-merge (rebase) June 20, 2022 13:29
@sondreso sondreso merged commit 2066b9a into equinor:main Jun 20, 2022
@pinkwah pinkwah deleted the pypi-pybind branch October 24, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use PyPI instead of Conan for the pybind11 package
3 participants