Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test that monitor can't connect to a secured server #9628

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

xjules
Copy link
Contributor

@xjules xjules commented Dec 30, 2024

Issue
Resolves #9624

Approach
Add test that monitor can't connect to a secured server.

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@xjules xjules self-assigned this Dec 30, 2024
Copy link

codspeed-hq bot commented Dec 30, 2024

CodSpeed Performance Report

Merging #9628 will not alter performance

Comparing xjules:add_test_encr_conn (0a439da) with main (0e9f8e0)

Summary

✅ 24 untouched benchmarks

@xjules xjules force-pushed the add_test_encr_conn branch 2 times, most recently from 79dafe6 to 6bb3a7f Compare January 24, 2025 09:07
@xjules xjules added the zmq label Jan 24, 2025
Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, I just have one small nitpicking comment 🥇

A simple test that provides either wrong or good server key.
@xjules xjules force-pushed the add_test_encr_conn branch from 89ea96e to 0a439da Compare January 24, 2025 11:39
Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! ☔ ⛈️

@xjules xjules merged commit d5ec233 into equinor:main Jan 24, 2025
27 checks passed
@xjules xjules deleted the add_test_encr_conn branch January 24, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zmq: write a test for non-encrypted connection to router requiring encryption
2 participants