Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try make pre/post experiment hook test not flaky #9677

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

yngve-sk
Copy link
Contributor

@yngve-sk yngve-sk commented Jan 8, 2025

Issue
Resolves #9671

Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #9677 will not alter performance

Comparing yngve-sk:25.01.08.make-prepostexp-test-not-flaky (cd78f00) with main (60fc8f8)

Summary

✅ 24 untouched benchmarks

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.66%. Comparing base (957b377) to head (cd78f00).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9677      +/-   ##
==========================================
- Coverage   91.67%   91.66%   -0.01%     
==========================================
  Files         424      424              
  Lines       26511    26552      +41     
==========================================
+ Hits        24305    24340      +35     
- Misses       2206     2212       +6     
Flag Coverage Δ
cli-tests 39.75% <66.66%> (+0.06%) ⬆️
everest-models-test 34.10% <66.66%> (+0.03%) ⬆️
gui-tests 74.24% <66.66%> (+<0.01%) ⬆️
integration-test 37.98% <66.66%> (+0.14%) ⬆️
performance-tests 51.52% <66.66%> (+0.04%) ⬆️
test 39.32% <66.66%> (+0.14%) ⬆️
unit-tests 74.20% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yngve-sk yngve-sk force-pushed the 25.01.08.make-prepostexp-test-not-flaky branch 13 times, most recently from 719e915 to 972c6de Compare January 14, 2025 09:03
@yngve-sk yngve-sk force-pushed the 25.01.08.make-prepostexp-test-not-flaky branch 2 times, most recently from 806e0a1 to c7a5eda Compare January 14, 2025 09:25
@yngve-sk yngve-sk force-pushed the 25.01.08.make-prepostexp-test-not-flaky branch from c7a5eda to a0fb136 Compare January 14, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky tests/ert/ui_tests/cli/test_cli.py::::test_that_pre_post_experiment_hook_works
2 participants