Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update forward model doc for FLOW #9741

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

berland
Copy link
Contributor

@berland berland commented Jan 15, 2025

Mention that it is now possible to select the version

Issue
Resolves outdated doc

Approach
✍🏻

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland changed the title Adjust forward model doc for FLOW Update forward model doc for FLOW Jan 15, 2025
@berland berland added the release-notes:documentation PR with only changes to documentation label Jan 15, 2025
@berland berland self-assigned this Jan 15, 2025
Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #9741 will improve performances by 12.82%

Comparing berland:flow_doc (73dd6b4) with main (9a1002d)

Summary

⚑ 2 improvements
βœ… 22 untouched benchmarks

Benchmarks breakdown

Benchmark main berland:flow_doc Change
⚑ test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-gen_data-get_record_observations] 1.7 ms 1.5 ms +12.82%
⚑ test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-summary-get_record_observations] 1.4 ms 1.3 ms +10.16%

Mention that it is now possible to select the version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:documentation PR with only changes to documentation
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

1 participant