Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup everest tests #9746

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Jan 15, 2025

Issue
Resolves #9727
Resolves #9728

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@DanSava DanSava force-pushed the speedup-everest-tests branch from 3c44846 to ca7ff8c Compare January 15, 2025 09:16
Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #9746 will degrade performances by 13.54%

Comparing DanSava:speedup-everest-tests (ae93312) with main (b6edc3b)

Summary

❌ 3 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main DanSava:speedup-everest-tests Change
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-gen_data-get_record_observations] 1.4 ms 1.6 ms -10.49%
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-gen_data_with_obs-get_record_observations] 2.4 ms 2.8 ms -13.54%
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-summary-get_record_observations] 1.2 ms 1.4 ms -11.02%

@DanSava DanSava self-assigned this Jan 15, 2025
run_model = EverestRunModel.create(config)
evaluator_server_config = evaluator_server_config_generator(run_model)
run_model.run_experiment(evaluator_server_config)
def test_that_one_experiment_creates_one_ensemble_per_batch(cached_example):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this could be sped up a bit more by limiting the number of batch, e.g. to two?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, guess not, its not running the case anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants