-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation egg model #115
Conversation
…an atribute called faults, so I consider it is better to ask for the atribute than to ask if it was instancieated
… understand why it doesnt apears in my master repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good start @tayloris!
I rewrote some sentences and fixed some spelling mistakes and put them as suggestions so you can easily decide to include them or not (you can do that directly on Github and then pull the changes to your own PC again).
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Removing the logo from this directory, We will add it in a different section of the documentation later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
I'm working on the documentation of the Egg model.
We can have a discussion of the styling because I'm new at sphinx.
The section about Pre-processing is important because several issues can be taken from there.
For instance, the issue of coplanar well depth is already an issue related to network generation that I should work on it (#16).
ES-MDA method do an "OK-ish" history match but there is room for improvement.