Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation egg model #115

Merged
merged 72 commits into from
Aug 21, 2020
Merged

Conversation

tayloris
Copy link
Collaborator

I'm working on the documentation of the Egg model.

We can have a discussion of the styling because I'm new at sphinx.

The section about Pre-processing is important because several issues can be taken from there.

For instance, the issue of coplanar well depth is already an issue related to network generation that I should work on it (#16).

ES-MDA method do an "OK-ish" history match but there is room for improvement.

tayloris added 30 commits April 4, 2020 13:40
…an atribute called faults, so I consider it is better to ask for the atribute than to ask if it was instancieated
Merge remote-tracking branch 'upstream/master'
… understand why it doesnt apears in my master repo
@tayloris tayloris requested a review from anders-kiaer August 13, 2020 19:10
Copy link
Collaborator

@wouterjdb wouterjdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good start @tayloris!

I rewrote some sentences and fixed some spelling mistakes and put them as suggestions so you can easily decide to include them or not (you can do that directly on Github and then pull the changes to your own PC again).

docs/egg_model_example.rst Outdated Show resolved Hide resolved
docs/egg_model_example.rst Outdated Show resolved Hide resolved
docs/egg_model_example.rst Outdated Show resolved Hide resolved
docs/egg_model_example.rst Outdated Show resolved Hide resolved
docs/egg_model_example.rst Show resolved Hide resolved
examples/egg_parameters.yml Outdated Show resolved Hide resolved
examples/egg_parameters.yml Show resolved Hide resolved
examples/egg_parameters.yml Outdated Show resolved Hide resolved
docs/egg_model_example.rst Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
tayloris and others added 13 commits August 18, 2020 15:54
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
Co-authored-by: Wouter J. de Bruin <[email protected]>
@wouterjdb wouterjdb added the documentation Improvements or additions to documentation label Aug 20, 2020
Removing the logo from this directory, We will add it in a different section of the documentation later
Copy link
Collaborator

@wouterjdb wouterjdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@tayloris tayloris merged commit 2491a95 into equinor:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants