Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding probability distribution options #251

Merged
merged 66 commits into from
Dec 17, 2020

Conversation

olelod
Copy link
Collaborator

@olelod olelod commented Nov 17, 2020

Insert a description of your pull request (PR) here, and check off the boxes below when they are done.


Contributor checklist

  • 🎉 This PR closes Data types/prior distributions in FlowNet #237 and Negative porosity when using mean and max in the config #210
  • 📜 I have broken down my PR into the following tasks:
    • Add possibility of defining more data types/priors in the config yml
      • Normal distribution
      • Truncated normal distribution
      • Lognormal distribution
      • Triangular distribution
      • Dirac distribution (constant)
    • Make all data types available for
      • Bulk volumne
      • Porosity
      • Permeability
      • Aquifer size
      • Fault multipliers
      • Contacts
      • Relative permeability
    • Update how min/max for a given mean/max or mean/min is found for a loguniform distribution
    • Update the update_distribution function in _run_ahm.py
    • Adding checks in the config parsing to make sure the defined distributions are ok
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md.
  • 📚 I have considered updating the documentation.

@wouterjdb wouterjdb added the enhancement New feature or request label Nov 17, 2020
@wouterjdb wouterjdb self-requested a review December 16, 2020 13:51
Copy link
Collaborator

@wouterjdb wouterjdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 (but too large too see the total picture, so I hope you did were very good with testing things!). Some tiny comments left and please change back the CI/CD testdata path.

src/flownet/config_parser/_config_parser.py Show resolved Hide resolved
src/flownet/config_parser/_config_parser.py Outdated Show resolved Hide resolved
src/flownet/parameters/probability_distributions.py Outdated Show resolved Hide resolved
@olelod olelod requested a review from wouterjdb December 17, 2020 10:24
Copy link
Collaborator

@wouterjdb wouterjdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤞

@olelod
Copy link
Collaborator Author

olelod commented Dec 17, 2020

Yes 🤞

@olelod olelod merged commit cd81a12 into master Dec 17, 2020
@olelod olelod deleted the adding-probability-distribution-options branch December 17, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data types/prior distributions in FlowNet
2 participants