-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding probability distribution options #251
Conversation
config parser cleanup
…equinor/flownet into adding-probability-distribution-options
…hub.com/equinor/flownet into adding-probability-distribution-options
…equinor/flownet into adding-probability-distribution-options
Added more in docstrings for probability_distributions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 (but too large too see the total picture, so I hope you did were very good with testing things!). Some tiny comments left and please change back the CI/CD testdata path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤞
Yes 🤞 |
Insert a description of your pull request (PR) here, and check off the boxes below when they are done.
Contributor checklist
CHANGELOG.md
.