Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I276 enabled new layering functionality #305

Merged

Conversation

LonnekevB
Copy link
Contributor

@LonnekevB LonnekevB commented Jan 20, 2021

Insert a description of your pull request (PR) here, and check off the boxes below when they are done.


Contributor checklist

@LonnekevB LonnekevB self-assigned this Jan 20, 2021
@wouterjdb wouterjdb added the enhancement New feature or request label Jan 21, 2021
@LonnekevB
Copy link
Contributor Author

image
The CI/CD now crashes on this. Don't really understand why it is even referring to a lambda function. Any ideas @wouterjdb ?

@wouterjdb
Copy link
Collaborator

The CI/CD now crashes on this. Don't really understand why it is even referring to a lambda function. Any ideas @wouterjdb ?

You are creating a collection called additional_flow_nodes and setting it to a value =2 one line later?

@LonnekevB
Copy link
Contributor Author

You are creating a collection called additional_flow_nodes and setting it to a value =2 one line later?

But that was already there. The only thing I added is adding additional_flownodes to the _generate_connections():

starts, ends = _generate_connections( df_coordinates=DF_COORDINATES, configuration=config, additional_flownodes=config.flownet.additional_flow_nodes, )

@wouterjdb
Copy link
Collaborator

wouterjdb commented Jan 21, 2021

If the test actually runs fine you could consider ignoring the pylint warning: # pylint: disable=no-member.

@LonnekevB LonnekevB marked this pull request as ready for review January 21, 2021 17:32
@LonnekevB LonnekevB requested a review from wouterjdb January 21, 2021 17:33
src/flownet/ahm/_run_ahm.py Outdated Show resolved Hide resolved
src/flownet/config_parser/_config_parser.py Outdated Show resolved Hide resolved
src/flownet/network_model/_generate_connections.py Outdated Show resolved Hide resolved
src/flownet/network_model/_generate_connections.py Outdated Show resolved Hide resolved
src/flownet/network_model/_generate_connections.py Outdated Show resolved Hide resolved
src/flownet/network_model/_generate_connections.py Outdated Show resolved Hide resolved
src/flownet/network_model/_generate_connections.py Outdated Show resolved Hide resolved
src/flownet/network_model/_generate_connections.py Outdated Show resolved Hide resolved
tests/test_generate_connections.py Outdated Show resolved Hide resolved
@wouterjdb
Copy link
Collaborator

wouterjdb commented Jan 22, 2021

Also add an item in the CHANGELOG. 👍

@wouterjdb wouterjdb merged commit 8c0f541 into equinor:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for multiple separated network in a single FlowNet
2 participants