Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed additional flow node input to list to allow various from layer to layer #342

Merged
merged 9 commits into from
Feb 26, 2021

Conversation

wouterjdb
Copy link
Collaborator

@wouterjdb wouterjdb commented Feb 26, 2021

Changed additional flow node input to list to allow various from layer to layer

This is a breaking change. YOu now have to supply the additional flow nodes as a list (also for a single numer!), like so:

additional_flow_nodes: [1]

or, for two layers,

additional_flow_nodes: [10,50]

Or, alternatively:

additional_flow_nodes:
  - 10
  - 50

Contributor checklist

  • 🎉 This PR closes Problems with layering option for Norne after removing unused well connections #328.
  • 📜 I have broken down my PR into the following tasks:
    • Expose additional nodes per layer to user
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md.
  • 📚 I have considered updating the documentation.

A new issue has been created as well #343.

@wouterjdb wouterjdb marked this pull request as ready for review February 26, 2021 13:51
@wouterjdb wouterjdb merged commit 4dddbf6 into equinor:master Feb 26, 2021
@wouterjdb wouterjdb deleted the i328-add-nlayers-per-layer branch February 26, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with layering option for Norne after removing unused well connections
2 participants