Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EQLNUM regions in FlowNet based on region parameter from simulation model #396

Merged
merged 2 commits into from
May 5, 2021

Conversation

olelod
Copy link
Collaborator

@olelod olelod commented May 4, 2021

When setting the scheme to regions_from_sim the EQLNUM regions in the input simulation model were used to generate the EQLNUM regions for the FlowNet model. This PR makes this more flexible by allowing any region parameter from the INIT file to be used.


Contributor checklist

  • 🎉 This PR closes #ISSUE_NUMBER.
  • 📜 I have broken down my PR into the following tasks:
    • Add region_parameter_from_sim_model to config_parser.py for equil
    • Add checks to config_parser.py
    • Change the generation of EQLNUM regions for FLOWNET to use the region_parameter_from_sim_model instead of the previously hard coded EQLNUM
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md.
  • 📚 I have considered updating the documentation.

@wouterjdb wouterjdb added the enhancement New feature or request label May 4, 2021
@wouterjdb wouterjdb added this to the HM open Norne Model milestone May 4, 2021
@olelod olelod marked this pull request as ready for review May 5, 2021 08:41
@wouterjdb wouterjdb merged commit 6603278 into equinor:master May 5, 2021
@olelod olelod deleted the equil-regions-from-sim branch May 5, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants