-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make regional multipliers for bulkvolume, porosity and permeability #404
Merged
wouterjdb
merged 12 commits into
equinor:master
from
olelod:volume-multiplier-per-region
May 28, 2021
Merged
Make regional multipliers for bulkvolume, porosity and permeability #404
wouterjdb
merged 12 commits into
equinor:master
from
olelod:volume-multiplier-per-region
May 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterjdb
approved these changes
May 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Don't forget to change back the test-data pointer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the possibility of adding regional multipliers for bulkvolume, permeability and porosity.
Contributor checklist
bulkvolume_mult_regional_scheme
,porosity_regional_scheme
andpermeability_regional_scheme
to themodel_parameters
in_config_parser.py
. Default values areindividual
, meaning no regional multiplier (alternatives areregions_from_sim
orglobal
)bulkvolume_mult_regional
,porosity_regional
andpermeability_regional
to themodel_parameters
in_config_parser.py
. If the*_regional_scheme
isindividual
the priors can be empty, otherwise they need to be defined (same way as the priors for individual tubes - not implemented possibility for different priors in different regions (such as for equilibrium regions or relative permeability)bulkvolume_mult_parameter_from_sim_model
,porosity_parameter_from_sim_model
andpermeability_parameter_from_sim_model
, telling which region parameter to look for in the input simulation model if the*_regional_scheme
is set toregions_from_sim
.CHANGELOG.md
.