Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove un-memoized function from render loop #1451

Merged
merged 9 commits into from
Mar 9, 2023
Merged

Conversation

hkfb
Copy link
Collaborator

@hkfb hkfb commented Mar 9, 2023

Fixes #1450

@hkfb hkfb added bug Something isn't working AspenTech Task owned by AspenTech map-component Issues related to the map component. labels Mar 9, 2023
@hkfb hkfb self-assigned this Mar 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Merging #1451 (f1963e8) into master (a6e6eb7) will decrease coverage by 0.02%.
The diff coverage is 2.27%.

@@            Coverage Diff             @@
##           master    #1451      +/-   ##
==========================================
- Coverage   33.49%   33.48%   -0.02%     
==========================================
  Files         153      153              
  Lines        8839     8842       +3     
  Branches     2334     2334              
==========================================
  Hits         2961     2961              
- Misses       5845     5848       +3     
  Partials       33       33              
Impacted Files Coverage Δ
...b/components/SubsurfaceViewer/SubsurfaceViewer.tsx 80.00% <ø> (ø)
...lib/components/SubsurfaceViewer/components/Map.tsx 48.50% <2.27%> (-0.34%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hkfb hkfb requested a review from nilscb March 9, 2023 09:35
@hkfb hkfb merged commit 1187daa into equinor:master Mar 9, 2023
@hkfb hkfb deleted the mouse_event branch March 9, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AspenTech Task owned by AspenTech bug Something isn't working map-component Issues related to the map component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve interactive performance when moving camera
3 participants