feat: consistency in hook UDVTs for ValidationDataView #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency, updating
to:
Validation hooks are defined in the spec as always running before a validation function, so we can make this simplification here. However, I see a slight edge in keeping
preUserOpValidationHook
,preRuntimeValidationHook
, andpreSignatureValidationHook
prefixed with "pre" in the rare event thatpostUserOpValidationHook
etc. are introduced in the future. This would allow for backward compatibility for v0.8 validation hook modules and the above proposed change also allows us to keep theValidationDataView
interface the same.I've opted to also update the storage in the reference account to store
HookConfig[]
instead ofModuleEntity[]
for simplicity.