-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update spec for v0.7.0 #32
Conversation
10b8de7
to
3cd3a0d
Compare
3cd3a0d
to
34fec34
Compare
540df6f
to
f298cfe
Compare
34fec34
to
d6253cd
Compare
f298cfe
to
1869bd4
Compare
d6253cd
to
894d3e7
Compare
894d3e7
to
c5e9fb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple comments!
@@ -87,7 +87,7 @@ Each step is modular, supporting different implementations for each execution fu | |||
|
|||
**Modular Smart Contract Accounts** **MUST** implement | |||
|
|||
- `IAccount` from [ERC-4337](./eip-4337.md). | |||
- `IAccount.sol` from [ERC-4337](./eip-4337.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice for consistency here, but eventually we should find a way to make this less solidity-specific.
c5e9fb3
to
2ba4978
Compare
9cfac88
to
4338c4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One tiny nit:
Various updates to the spec and reference implementation interfaces. This builds on the updates that were made in #20.
canSpendNativeToken
to clarify that the plugin can spend up to the amount that it sends to the account in the same call even if this value isfalse
.PluginManifest
'sdependencyInterfaceIds
comment no longer includes hooks.installPlugin
's comment on thedependencies
param is now explicit about eachFunctionReference
being a validation function.callbacksSucceeded
param of thePluginUninstalled
event toonUninstallSucceeded
, as there are no longer multiple callbacks for uninstalls after feat: [v0.7.0] Cut permitted call hooks & injection #20.pluginInitData
param ofinstallPlugin
topluginInstallData
to be more consistent with thepluginUninstallData
param ofuninstallPlugin
.FunctionReference
type declaration has been moved fromIAccountLoupe.sol
toIPluginManager.sol
, since the former is an optional interface.installPlugin
updates:interfaceIds
, which was implied but missing.PluginInstall
event, which was implied but missing.uninstallPlugin
updates:PluginUninstalled
event, which was implied but missing.