task REST endpoint returning 'null' instead of 404

[icastro28]

While testing the REST endpoints provided, I noticed that when the GET /task endpoint is called, and no tasks are currently RUNNING, the response code is wrong since I'm getting a 200 code with 'null' value in the body, instead of getting a 404 as specified in the Swagger.yaml file.

[keis]

Nice catch @icastro28

Returning null is super weird. 200 is IMHO more correct as the list of running tasks still exists even when it is empty. But regardless we should update one or both so that the documentation is correct.

[icastro28]

Fair enough, but yeah null is not good.

[sheepkiller]

hi @icastro28 ,

which version are you running ? PR #115 should have fixed that (200 + empty array). Maybe there's a regression somewhere.

[keis]

Aha, I thought it sounded familiar. Looks like it didn't make it into a tagged release up until recently.

@alde Did you get 0.24 to work?

[alde]

@keis: yes, as far as I could test. Tagged 0.24.1 with the fix.

[icastro28]

I didn't use a specifix tag, I used latest.

Ivan
El martes, 13 de septiembre de 2016, sheepkiller [email protected]
escribió:

hi @icastro28 https://github.com/icastro28 ,

which version are you running ? PR #115
#115 should have fixed that (200

• empty array). Maybe there's a regression somewhere.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#135 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFyd5QNZJCarnI6HXS0wy-T5QtHkJ5Bvks5qplwIgaJpZM4J68VL
.