Support adding uris to command info #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extract flag is set based on the same list of suffixes as used by marathon
|
I'm skeptical to the name "uri", it is very unclear what it means without understanding the mesos api. |
|
I'm not super happy with it either but could not come up with anything better so I just used what it's called in the mesos protobuf and marathon apis, "uris" |
|
Fair enough. Please add it to the readme then at least. :) |
keis
force-pushed
the
command-info-uris
branch
from
287b0e0 to
d0a5753
Compare
|
Good point. updated. Also made sure we got some sweet syntax highlighting in the readme going |
|
|
keis
added a commit
that referenced
this pull request
Jan 11, 2016
Support adding uris to command info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extract flag is set based on the same list of suffixes as used by
marathon