Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Update phpstan/phpstan and friends #101

Merged
merged 2 commits into from
Dec 22, 2019
Merged

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Dec 14, 2019

This PR

  • updates phpstan/phpstan and friends
  • fixes issues reported via static analysis

@localheinz localheinz self-assigned this Dec 14, 2019
@codecov
Copy link

codecov bot commented Dec 14, 2019

Codecov Report

Merging #101 into master will decrease coverage by 1.44%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #101      +/-   ##
============================================
- Coverage       100%   98.55%   -1.45%     
- Complexity       47       48       +1     
============================================
  Files             5        6       +1     
  Lines           134      138       +4     
============================================
+ Hits            134      136       +2     
- Misses            0        2       +2
Impacted Files Coverage Δ Complexity Δ
src/Exception/MultipleDefinitionsFound.php 100% <ø> (ø) 2 <0> (ø) ⬇️
src/Construct.php 100% <ø> (ø) 7 <0> (ø) ⬇️
src/Constructs.php 97.77% <0%> (-2.23%) 34 <0> (ø)
src/Exception/ShouldNotHappen.php 100% <100%> (ø) 1 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e290ab0...7fccd37. Read the comment docs.

@localheinz localheinz marked this pull request as ready for review December 22, 2019 09:34
@localheinz localheinz force-pushed the feature/phpstan branch 3 times, most recently from 28e7780 to 01554a6 Compare December 22, 2019 09:44
@localheinz localheinz merged commit 10b6d6d into master Dec 22, 2019
@localheinz localheinz deleted the feature/phpstan branch December 22, 2019 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant