Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Properly determine classy name within namespace with single segment #343

Merged
merged 2 commits into from
Feb 1, 2021

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Feb 1, 2021

This pull request

  • asserts that a class name is determined within a namespace with a single segment
  • properly determines a classy name within a namespace with single segment

Fixes #326.

@localheinz localheinz self-assigned this Feb 1, 2021
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #343 (ba801da) into main (7dfb744) will decrease coverage by 0.67%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #343      +/-   ##
============================================
- Coverage     97.91%   97.24%   -0.68%     
  Complexity       50       50              
============================================
  Files             6        6              
  Lines           144      145       +1     
============================================
  Hits            141      141              
- Misses            3        4       +1     
Impacted Files Coverage Δ Complexity Δ
src/Constructs.php 95.78% <50.00%> (-1.02%) 36.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dfb744...1b58328. Read the comment docs.

@localheinz localheinz marked this pull request as ready for review February 1, 2021 08:03
@localheinz localheinz force-pushed the fix/single-namespace-segment branch 2 times, most recently from 56533ff to 54c33b2 Compare February 1, 2021 08:08
@localheinz localheinz force-pushed the fix/single-namespace-segment branch from 54c33b2 to b8b84dc Compare February 1, 2021 08:22
@localheinz localheinz force-pushed the fix/single-namespace-segment branch from f01fc8b to 1b58328 Compare February 1, 2021 08:24
@ergebnis-bot ergebnis-bot self-assigned this Feb 1, 2021
@ergebnis-bot ergebnis-bot merged commit 72840bd into main Feb 1, 2021
@ergebnis-bot ergebnis-bot deleted the fix/single-namespace-segment branch February 1, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Classes in single level namespace not resovled correctly for PHP 8
2 participants