Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Drop support for PHP 7.3 #486

Merged
merged 1 commit into from
Dec 30, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions .github/settings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,11 @@ branches:
required_approving_review_count: 1
required_status_checks:
contexts:
- "Code Coverage (7.3, locked)"
- "Coding Standards (7.3, locked)"
- "Dependency Analysis (7.3, locked)"
- "Mutation Tests (7.3, locked)"
- "Static Code Analysis (7.3, locked)"
- "Tests (7.3, highest)"
- "Tests (7.3, locked)"
- "Tests (7.3, lowest)"
- "Code Coverage (7.4, locked)"
- "Coding Standards (7.4, locked)"
- "Dependency Analysis (7.4, locked)"
- "Mutation Tests (7.4, locked)"
- "Static Code Analysis (7.4, locked)"
- "Tests (7.4, highest)"
- "Tests (7.4, locked)"
- "Tests (7.4, lowest)"
Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/integrate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
strategy:
matrix:
php-version:
- "7.3"
- "7.4"

dependencies:
- "locked"
Expand Down Expand Up @@ -72,7 +72,7 @@ jobs:
strategy:
matrix:
php-version:
- "7.3"
- "7.4"

dependencies:
- "locked"
Expand Down Expand Up @@ -137,7 +137,7 @@ jobs:
strategy:
matrix:
php-version:
- "7.3"
- "7.4"

dependencies:
- "locked"
Expand Down Expand Up @@ -179,7 +179,7 @@ jobs:
strategy:
matrix:
php-version:
- "7.3"
- "7.4"

dependencies:
- "locked"
Expand Down Expand Up @@ -221,7 +221,7 @@ jobs:
strategy:
matrix:
php-version:
- "7.3"
- "7.4"

dependencies:
- "locked"
Expand Down Expand Up @@ -266,7 +266,6 @@ jobs:
strategy:
matrix:
php-version:
- "7.3"
- "7.4"
- "8.0"
- "8.1"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/renew.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
strategy:
matrix:
php-version:
- "7.3"
- "7.4"

dependencies:
- "locked"
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ For a full diff see [`1.2.0...main`][1.2.0...main].
### Fixed

- Dropped support for PHP 7.2 ([#481]), by [@localheinz]
- Dropped support for PHP 7.3 ([#486]), by [@localheinz]

## [`1.2.0`][1.2.0]

Expand Down Expand Up @@ -139,6 +140,7 @@ For a full diff see [`0.4.0...0.5.0`][0.4.0...0.5.0].
[#467]: https://github.com/ergebnis/classy/pull/467
[#478]: https://github.com/ergebnis/classy/pull/478
[#481]: https://github.com/ergebnis/classy/pull/481
[#486]: https://github.com/ergebnis/classy/pull/486

[@ergebnis]: https://github.com/ergebnis
[@localheinz]: https://github.com/localheinz
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"source": "https://github.com/ergebnis/classy"
},
"require": {
"php": "^7.3 || ^8.0",
"php": "^7.4 || ^8.0",
"ext-tokenizer": "*"
},
"require-dev": {
Expand Down Expand Up @@ -56,7 +56,7 @@
"ergebnis/composer-normalize": true
},
"platform": {
"php": "7.3.32"
"php": "7.4.26"
},
"preferred-install": "dist",
"sort-packages": true
Expand Down
8 changes: 4 additions & 4 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 0 additions & 9 deletions test/Fixture/Classy/Php73/WithinNamespace/source.php

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Ergebnis\Classy\Test\Fixture\Classy\Php73\WithMethodsNamedAfterKeywords;
namespace Ergebnis\Classy\Test\Fixture\Classy\Php74\WithMethodsNamedAfterKeywords;

class Foo
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Ergebnis\Classy\Test\Fixture\Classy\Php73\WithMethodsNamedAfterKeywordsAndReturnType;
namespace Ergebnis\Classy\Test\Fixture\Classy\Php74\WithMethodsNamedAfterKeywordsAndReturnType;


class Foo
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Ergebnis\Classy\Test\Fixture\Classy\Php73\WithinMultipleNamespaces\Foo;
namespace Ergebnis\Classy\Test\Fixture\Classy\Php74\WithinMultipleNamespaces\Foo;
{
class Foo {}

Expand All @@ -9,7 +9,7 @@ interface Bar {}
trait Baz {}
}

namespace Ergebnis\Classy\Test\Fixture\Classy\Php73\WithinMultipleNamespaces\Bar;
namespace Ergebnis\Classy\Test\Fixture\Classy\Php74\WithinMultipleNamespaces\Bar;
{
class Foo {}

Expand Down
9 changes: 9 additions & 0 deletions test/Fixture/Classy/Php74/WithinNamespace/source.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?php

namespace Ergebnis\Classy\Test\Fixture\Classy\Php74\WithinNamespace;

class Foo {}

interface Bar {}

trait Baz {}
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Ergebnis\Classy\Test\Fixture\Classy\Php73\WithinNamespaceAndMultiLineComments;
namespace Ergebnis\Classy\Test\Fixture\Classy\Php74\WithinNamespaceAndMultiLineComments;

/* foo */ class /* bar */ Foo /* baz */ {}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Ergebnis\Classy\Test\Fixture\Classy\Php73\WithinNamespaceAndShellStyleComments;
namespace Ergebnis\Classy\Test\Fixture\Classy\Php74\WithinNamespaceAndShellStyleComments;

class # foo
Foo # bar
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Ergebnis\Classy\Test\Fixture\Classy\Php73\WithinNamespaceAndSingleLineComments;
namespace Ergebnis\Classy\Test\Fixture\Classy\Php74\WithinNamespaceAndSingleLineComments;

class // foo
Foo // bar
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Ergebnis\Classy\Test\Fixture\Classy\Php73\WithinNamespaceWithBraces
namespace Ergebnis\Classy\Test\Fixture\Classy\Php74\WithinNamespaceWithBraces
{
class Foo {}

Expand Down
Loading