Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not require composer.json to be writable when using --dry-run option #177

Merged
merged 1 commit into from
May 23, 2019

Conversation

localheinz
Copy link
Member

This PR

  • removes the requirement for composer.json to be writable when using the --dry-run option

@localheinz localheinz added the bug label May 23, 2019
@localheinz localheinz self-assigned this May 23, 2019
@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #177 into 1.x will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##                1.x     #177   +/-   ##
=========================================
  Coverage     82.68%   82.68%           
- Complexity       36       37    +1     
=========================================
  Files             2        2           
  Lines           179      179           
=========================================
  Hits            148      148           
  Misses           31       31
Impacted Files Coverage Δ Complexity Δ
src/Command/NormalizeCommand.php 87.05% <100%> (ø) 34 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4062e2...2c3092e. Read the comment docs.

@localheinz localheinz merged commit 367d861 into 1.x May 23, 2019
@localheinz localheinz deleted the fix/dry-run branch May 23, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant