Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Actually run 'composer validate' #297

Merged
merged 1 commit into from
Dec 26, 2019
Merged

Fix: Actually run 'composer validate' #297

merged 1 commit into from
Dec 26, 2019

Conversation

localheinz
Copy link
Member

This PR

  • actually runs composer validate when the validation failed

Fixes #243.

@localheinz localheinz added the bug label Dec 26, 2019
@localheinz localheinz self-assigned this Dec 26, 2019
@codecov
Copy link

codecov bot commented Dec 26, 2019

Codecov Report

Merging #297 into master will increase coverage by 4.94%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #297      +/-   ##
============================================
+ Coverage     84.94%   89.89%   +4.94%     
  Complexity       37       37              
============================================
  Files             3        3              
  Lines           186      188       +2     
============================================
+ Hits            158      169      +11     
+ Misses           28       19       -9
Impacted Files Coverage Δ Complexity Δ
src/Command/NormalizeCommand.php 91.95% <100%> (+5.32%) 33 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e0baff...f6d0485. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve DX on "Original JSON is not valid according to schema" error
1 participant