Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Avoid display of override message when updating lock file #420

Merged
merged 2 commits into from
May 1, 2020

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented May 1, 2020

This PR

  • asserts that override messages are not displayed when updating lock file
  • avoids display of override messages when updating lock file

Fixes #418.

@localheinz localheinz added the bug label May 1, 2020
@localheinz localheinz self-assigned this May 1, 2020
@localheinz localheinz force-pushed the fix/override branch 2 times, most recently from 8ad0b51 to 3f53f13 Compare May 1, 2020 10:19
@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #420 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #420      +/-   ##
============================================
+ Coverage     80.82%   80.92%   +0.09%     
  Complexity       41       41              
============================================
  Files             4        4              
  Lines           193      194       +1     
============================================
+ Hits            156      157       +1     
  Misses           37       37              
Impacted Files Coverage Δ Complexity Δ
src/Command/NormalizeCommand.php 85.54% <100.00%> (+0.08%) 34.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 287f20d...024280e. Read the comment docs.

@localheinz localheinz merged commit e303f54 into master May 1, 2020
@localheinz localheinz deleted the fix/override branch May 1, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"A script would override a Composer command and has been skipped" warnings
1 participant