Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend only updating the lock file in exception #86

Merged
merged 2 commits into from
Oct 7, 2018
Merged

Recommend only updating the lock file in exception #86

merged 2 commits into from
Oct 7, 2018

Conversation

svenluijten
Copy link
Contributor

This PR will recommend the use of composer update --lock instead of composer update. This will ensure the composer.lock file is updated to match what's in composer.json, without causing any minor/patch version bumps. You can read more about this option in the Composer documentation.

@svenluijten svenluijten changed the title Recommend only updating the lock file in error Recommend only updating the lock file in exception Oct 7, 2018
@codecov
Copy link

codecov bot commented Oct 7, 2018

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #86   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity       69     69           
=======================================
  Files             7      7           
  Lines           264    264           
=======================================
  Hits            264    264
Impacted Files Coverage Δ Complexity Δ
src/Command/NormalizeCommand.php 100% <100%> (ø) 33 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021b226...3dd6515. Read the comment docs.

@localheinz localheinz self-assigned this Oct 7, 2018
Copy link
Member

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 👍

@localheinz localheinz merged commit c28f2e9 into ergebnis:master Oct 7, 2018
@localheinz
Copy link
Member

Thank you, @svenluijten!

@svenluijten svenluijten deleted the patch-1 branch October 7, 2018 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants