Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Extract MaximumCount #663

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Enhancement: Extract MaximumCount #663

merged 1 commit into from
Feb 22, 2025

Conversation

localheinz
Copy link
Member

This pull request

  • extracts MaximumCount

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 70.37037% with 8 lines in your changes missing coverage. Please review.

Project coverage is 47.72%. Comparing base (b08645f) to head (cc45618).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/Extension.php 0.00% 6 Missing ⚠️
src/Reporter/DefaultReporter.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #663      +/-   ##
============================================
- Coverage     57.49%   47.72%   -9.78%     
- Complexity      124      130       +6     
============================================
  Files            30       32       +2     
  Lines           687      702      +15     
============================================
- Hits            395      335      -60     
- Misses          292      367      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@localheinz localheinz merged commit 77b8430 into main Feb 22, 2025
75 of 76 checks passed
@localheinz localheinz deleted the feature/extract branch February 22, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants