DOPE-247: added array star function, tests and cm extensions #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansigi
requested changes
Nov 22, 2024
There was a problem hiding this comment.
Please also add support for this syntax [*]: https://docs.couchbase.com/cloud/n1ql/n1ql-language-reference/arrayfun.html#array-references
pgruntz
requested changes
Nov 25, 2024
core/src/main/kotlin/ch/ergon/dope/resolvable/expression/unaliased/type/Parameter.kt
Outdated
Show resolved
Hide resolved
.../dope/resolvable/expression/unaliased/type/function/arrayfunction/ArrayStarExpressionTest.kt
Show resolved
Hide resolved
.../dope/resolvable/expression/unaliased/type/function/arrayfunction/ArrayStarExpressionTest.kt
Show resolved
Hide resolved
...rgon/dope/resolvable/expression/unaliased/type/function/arrayfunction/ArrayStarExpression.kt
Outdated
Show resolved
Hide resolved
...rgon/dope/resolvable/expression/unaliased/type/function/arrayfunction/ArrayStarExpression.kt
Outdated
Show resolved
Hide resolved
…dope-247-array-star-function
jansigi
reviewed
Jan 16, 2025
| override fun toDopeQuery(manager: DopeQueryManager): DopeQuery { | ||
| val objectArrayDopeQuery = objectArray.toDopeQuery(manager) | ||
| return DopeQuery( | ||
| queryString = "${objectArrayDopeQuery.queryString}[*]", |
There was a problem hiding this comment.
use the pre existing const ASTERISK_STRING for *
jansigi
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.couchbase.com/cloud/n1ql/n1ql-language-reference/arrayfun.html#fn-array-star