Remove invalid headers on chain repair #1856
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragmaxim
reviewed
Oct 2, 2022
| } | ||
| if(updatedHeightIdsValue.isEmpty) { | ||
| //could be the case after bestHeaderHeight | ||
| history.historyStorage.remove(Array(history.heightIdsKey(h)), Nil) |
There was a problem hiding this comment.
Shouldn't we also remove the Modifier at this height? Not just index? Or is there an idempotency in place that the modifer gets overriden if index is empty?
pragmaxim
reviewed
Oct 2, 2022
| //could be the case after bestHeaderHeight | ||
| history.historyStorage.remove(Array(history.heightIdsKey(h)), Nil) | ||
| } else { | ||
| history.historyStorage.insert(Array(history.heightIdsKey(h) -> updatedHeightIdsValue), Nil) |
There was a problem hiding this comment.
I don't understand what we are updating the valid header index with and why, that would need at least a comment
aslesarenko
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike previous attempts to repair db of node being stuck, this one is removing invalid blocks in the past (in 128 blocks depth from the tip) and in future (not just the next height).
Could be useful to unstuck with pre 4,0,100 databases stuck after the HF.