Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I744 add missing functions #745

Merged
merged 4 commits into from
May 11, 2024
Merged

I744 add missing functions #745

merged 4 commits into from
May 11, 2024

Conversation

Alesfatalis
Copy link
Contributor

closes #744

@Alesfatalis
add functions for address
da3f78c 
- to ergo tree
- from public key bytes
@Alesfatalis Alesfatalis force-pushed the i744-add-missing-functions branch from 29c5607 to c3d7bb7 Compare May 9, 2024 00:11
@Alesfatalis Alesfatalis force-pushed the i744-add-missing-functions branch from c3d7bb7 to 797a1cb Compare May 10, 2024 15:51
@coveralls
Copy link

coveralls commented May 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9036120357

Details

  • 11 of 22 (50.0%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 80.445%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ergo-lib/src/chain/parameters.rs 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
ergotree-ir/src/serialization/types.rs 8 80.49%
Totals Coverage Status
Change from base Build 8982795251: 0.06%
Covered Lines: 10737
Relevant Lines: 13347
💛 - Coveralls

@Alesfatalis Alesfatalis force-pushed the i744-add-missing-functions branch from a37ab58 to f06171a Compare May 10, 2024 17:41
@SethDusek SethDusek self-requested a review May 10, 2024 18:03
SethDusek
SethDusek approved these changes May 11, 2024
View reviewed changes
Copy link
Collaborator

@SethDusek SethDusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SethDusek SethDusek merged commit 1801136 into ergoplatform:develop May 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethDusek SethDusek SethDusek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing functions for address and implement parameters from json for c-bindings
3 participants
@Alesfatalis @coveralls @SethDusek