Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Global.deserialize method #800

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

SethDusek
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Jan 5, 2025

Pull Request Test Coverage Report for Build 12858763292

Details

  • 19 of 22 (86.36%) changed or added relevant lines in 3 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 78.576%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ergotree-interpreter/src/eval/sglobal.rs 8 11 72.73%
Files with Coverage Reduction New Missed Lines %
ergotree-ir/src/serialization/types.rs 8 81.47%
Totals Coverage Status
Change from base Build 12853076213: 0.004%
Covered Lines: 11135
Relevant Lines: 14171

💛 - Coveralls

@SethDusek SethDusek force-pushed the globaldeserialize6.0 branch from 22e2338 to fe1668c Compare January 10, 2025 15:03
Copy link
Member

@kushti kushti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please check notes!

ergotree-interpreter/src/eval/sglobal.rs Outdated Show resolved Hide resolved
@@ -486,11 +535,41 @@ mod tests {
);
}

#[test]
fn deserialize_group_element() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to test more types

Copy link
Collaborator Author

@SethDusek SethDusek Jan 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roundtrip deserialization for all types is covered in serialize_roundtrip test

@SethDusek SethDusek force-pushed the globaldeserialize6.0 branch 2 times, most recently from 5f75c2d to a3f1b55 Compare January 18, 2025 07:49
@SethDusek SethDusek requested a review from kushti January 18, 2025 08:10
@SethDusek SethDusek force-pushed the globaldeserialize6.0 branch from a3f1b55 to 4bcc8b5 Compare January 20, 2025 00:45
@kushti
Copy link
Member

kushti commented Jan 27, 2025

@SethDusek looks good!

@SethDusek SethDusek merged commit 058b317 into ergoplatform:develop Jan 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants