-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Global.deserialize method #800
Add Global.deserialize method #800
Conversation
Pull Request Test Coverage Report for Build 12858763292Details
💛 - Coveralls |
22e2338
to
fe1668c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but please check notes!
@@ -486,11 +535,41 @@ mod tests { | |||
); | |||
} | |||
|
|||
#[test] | |||
fn deserialize_group_element() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to test more types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roundtrip deserialization for all types is covered in serialize_roundtrip test
5f75c2d
to
a3f1b55
Compare
a3f1b55
to
4bcc8b5
Compare
@SethDusek looks good! |
No description provided.