-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: starting multiple instances causes error #28
Comments
sebgie
added a commit
to sebgie/grunt-express-server
that referenced
this issue
Dec 5, 2013
closes ericclemmons#28 - added stopdone to wait for server to stop - renamed done to startdone - added testsequence which is able to reproduce the bug without my changes
Published v0.4.8 with this fix. Thanks for the test, detailed bug report, and the extremely simple fix :) |
sebgie
added a commit
to sebgie/grunt-express-server
that referenced
this issue
Dec 6, 2013
closes ericclemmons#28 closes ericclemmons#30 - added stopdone to wait for server to stop - renamed done to startdone - added conditional for `grunt.task.current.async()` - added testsequence which is able to reproduce the bug without my changes to server.js - added `express:defaults` without `express:defaults:stop` at the end of the file to reproduce missing 'async'
This was referenced Dec 16, 2013
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We use
grunt-express-server
for automated Travis builds. Our tests start the same instance of an express server multiple times in a row. The following flow is the result:express:test
(waiting for output)finished() -> done()
is executedexpress:test:stop
express:test
(waiting for output)doneFunction
ofgrunt.util.spawn()
executesfinished() -> done()
and the second server is not waiting for output anymore.The text was updated successfully, but these errors were encountered: