Add py310 support #74

ocefpaf · 2022-08-03T18:22:18Z

Added a test matrix to be sure we find some corner cases.

Closes #69

add py310 support
make stdlib-list a py<310 dependency
fix false positive in our tests

codecov-commenter · 2022-08-03T18:26:33Z

Codecov Report

Merging #74 (a1db75a) into master (7ea5755) will decrease coverage by 0.21%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
- Coverage   92.32%   92.10%   -0.22%     
==========================================
  Files           6        7       +1     
  Lines         456      456              
==========================================
- Hits          421      420       -1     
- Misses         35       36       +1

Impacted Files	Coverage Δ
depfinder/stdliblist.py	`75.00% <75.00%> (ø)`
depfinder/inspection.py	`88.72% <100.00%> (-0.25%)`	⬇️
depfinder/reports.py	`96.55% <100.00%> (+1.09%)`	⬆️
depfinder/utils.py	`77.41% <100.00%> (-2.59%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

depfinder/inspection.py

.github/workflows/tests.yml

zmoon · 2022-08-03T22:09:18Z

.github/workflows/tests.yml


-      - uses: conda-incubator/setup-miniconda@v2
+      - name: Setup Micromamba
+        uses: mamba-org/provision-with-micromamba@main
        with:


I was thinking about the caching options but I guess that wouldn't help since no conda env yml file. But maybe if use extra-specs as mentioned below.

Probably. I only use cache for big envs, this one is not that heavy but we can try that in another PR I already added too much in this one.

.github/workflows/tests.yml

zmoon · 2022-08-03T22:14:54Z

depfinder/inspection.py

@@ -36,7 +36,7 @@
 from collections import defaultdict
 from typing import Union

-from stdlib_list import stdlib_list
+from .stdliblist import builtin_modules


Could just be me but I find stdliblist a bit ugly / hard to read, maybe the module could be stdlib_list_ instead or something

Super ugly! I'm terrible with names. I'm OK with stdlib_list_. Let's see what @ericdill thinks and we'll rename.

Actually, let's hold this one for a bit. I forgot I'm also a maintainer of stdlib-list and these changes should be there instead.

Let's see what @ericdill thinks and we'll rename.

FWIW you don't need my approval for anything in this project. do whatever you think is best. i trust you on this stuff

i'd prefix this to be _stdlib_list but it's an internal detail so we can fix it in post

zmoon · 2022-08-03T22:27:27Z

Also did you see the

test.py::test_for_smoke
  <unknown>:485: DeprecationWarning: invalid escape sequence \s

in the test run? Not part of this PR though.

zmoon · 2022-08-03T22:35:45Z

depfinder/stdliblist.py

+    builtin_modules = stdlib_list(pyver)
+    del pyver
+except ImportError:
+    # assuming py>=3.10


This should be the case now, but if stdlib-list was somehow missing in Python <3.10 situation, then the error message could be a bit confusing?

It is listed as a dependency for py<3.10, so the only way that scenario would happen is in a broken installation with "no-deps" and people doing that are usually experts. The error message would be:

AttributeError: module 'sys' has no attribute 'stdlib_module_names'

That is, IMO, the correct information an advanced users should know but I accept suggestions for a better one.

Yeah, I suppose you are right, that makes sense.

I guess I would lean towards switching the try and except parts or doing a sys.version_info check.

And I know you're going another way here, but I also feel like it could be useful to have this in stdlib-list, e.g. to support listing the 3.10 stdlib from an older Python version, and to reduce the number of times this sort of code here would have to be written perhaps.

Yep. It makes sense to put in stliblib-list. I completely forgot I am a maintainer there and I can port this over tomorrow.

ocefpaf · 2022-08-03T22:36:00Z

in the test run? Not part of this PR though.

Not sure where that is coming from but we should probably fix it in another PR.

beckermr · 2022-08-04T12:07:35Z

My approval never was or is needed here, but I am LGTMing this in an effort to get it merged ASAP.

Thank you @ocefpaf!

Co-authored-by: Zachary Moon <[email protected]>

ericdill · 2022-08-04T18:43:55Z

i pushed a change to fix the tests but now we're failing because of the change introduced in #76. the reason for this is that python-stdlib-list has the builtin as "concurrent.futures". so when we're using python-stdlib-list, that's the thing that gets reported. The new way we're finding modules,

    builtin_modules = list(set(list(sys.stdlib_module_names) + list(sys.builtin_module_names)))

only has the top-level namespace (i.e., it only shows concurrent).

so now i think the solution probably has to be to have separate tests for py<=3.9 and py>=3.10. i'll give a think on how to implement that

…tdlib-list and when not using it

ericdill · 2022-08-04T18:52:55Z

🤞🏻 584c8a9 🤞🏻 should fix it

ericdill · 2022-08-04T21:47:22Z

:485: DeprecationWarning: invalid escape sequence \s

@zmoon iirc this was from some weird windows encoding thing that CJ hit a while back. it's in one of the test files somewhere i think. could be a thing to look into later

ericdill · 2022-08-04T21:47:27Z

yolo

ericdill · 2022-08-04T21:47:59Z

@ocefpaf it's embarassing to admit but i have no idea how to release a new version of this

ericdill · 2022-08-04T21:48:43Z

oh actually looks like @beckermr did the last release. want to do another?

ocefpaf · 2022-08-05T00:14:59Z

@ocefpaf it's embarassing to admit but i have no idea how to release a new version of this

I'm just tagging and using GitHub auto generated changelog. See https://github.com/ericdill/depfinder/releases/tag/V2.9.0

I'll add some extra stuff to automatically push to PyPI soon but I can push this one manually.

ocefpaf · 2022-08-05T00:17:49Z

@ericdill I do plan to move most of this stuff to stdlib-list at some point and "archive" that project. In theory we won't need it again for Python >=3.10.

ericdill · 2022-08-05T02:58:15Z

thanks for releasing!

conda-forge PR conda-forge/depfinder-feedstock#29

beckermr · 2022-08-05T10:25:04Z

Something is failing for python 3.10 in the feedstock pr. Can you all look?

ocefpaf force-pushed the py310 branch from 92834b6 to ed82569 Compare August 3, 2022 18:24

zmoon reviewed Aug 3, 2022

View reviewed changes

depfinder/inspection.py Outdated Show resolved Hide resolved

ocefpaf mentioned this pull request Aug 3, 2022

Fix website #72

Merged

ocefpaf force-pushed the py310 branch 2 times, most recently from 45f0c5a to 60fd24d Compare August 3, 2022 21:57

ocefpaf marked this pull request as ready for review August 3, 2022 21:57

ocefpaf requested review from zmoon and ericdill and removed request for zmoon August 3, 2022 21:57

zmoon reviewed Aug 3, 2022

View reviewed changes

ocefpaf marked this pull request as draft August 3, 2022 23:27

ocefpaf force-pushed the py310 branch from 01807f6 to 6266e69 Compare August 3, 2022 23:54

beckermr approved these changes Aug 4, 2022

View reviewed changes

ocefpaf force-pushed the py310 branch from 6266e69 to bac14cf Compare August 4, 2022 18:12

ocefpaf and others added 3 commits August 4, 2022 15:22

py310 support

ccfbeee

Update .github/workflows/tests.yml

381a6a7

Co-authored-by: Zachary Moon <[email protected]>

try default shell

ba11cf1

ocefpaf force-pushed the py310 branch from bac14cf to ba11cf1 Compare August 4, 2022 18:22

Don't explicitly call stdlib_list any more

a1db75a

Add test that parses nested namespace builtins correctly when using s…

584c8a9

…tdlib-list and when not using it

ericdill marked this pull request as ready for review August 4, 2022 21:45

ericdill merged commit e7d8463 into ericdill:master Aug 4, 2022

ocefpaf deleted the py310 branch August 5, 2022 00:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add py310 support #74

Add py310 support #74

ocefpaf commented Aug 3, 2022 •

edited

Loading

codecov-commenter commented Aug 3, 2022 •

edited

Loading

zmoon Aug 3, 2022 •

edited

Loading

ocefpaf Aug 3, 2022

zmoon Aug 3, 2022

ocefpaf Aug 3, 2022

ocefpaf Aug 3, 2022

ericdill Aug 3, 2022

ericdill Aug 4, 2022

zmoon commented Aug 3, 2022

zmoon Aug 3, 2022 •

edited

Loading

ocefpaf Aug 3, 2022

zmoon Aug 3, 2022 •

edited

Loading

ocefpaf Aug 3, 2022

ocefpaf commented Aug 3, 2022

beckermr commented Aug 4, 2022

ericdill commented Aug 4, 2022

ericdill commented Aug 4, 2022

ericdill commented Aug 4, 2022

ericdill commented Aug 4, 2022

ericdill commented Aug 4, 2022

ericdill commented Aug 4, 2022

ocefpaf commented Aug 5, 2022

ocefpaf commented Aug 5, 2022

ericdill commented Aug 5, 2022

beckermr commented Aug 5, 2022

Add py310 support #74

Add py310 support #74

Conversation

ocefpaf commented Aug 3, 2022 • edited Loading

codecov-commenter commented Aug 3, 2022 • edited Loading

Codecov Report

zmoon Aug 3, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zmoon commented Aug 3, 2022

zmoon Aug 3, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zmoon Aug 3, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ocefpaf commented Aug 3, 2022

beckermr commented Aug 4, 2022

ericdill commented Aug 4, 2022

ericdill commented Aug 4, 2022

ericdill commented Aug 4, 2022

ericdill commented Aug 4, 2022

ericdill commented Aug 4, 2022

ericdill commented Aug 4, 2022

ocefpaf commented Aug 5, 2022

ocefpaf commented Aug 5, 2022

ericdill commented Aug 5, 2022

beckermr commented Aug 5, 2022

ocefpaf commented Aug 3, 2022 •

edited

Loading

codecov-commenter commented Aug 3, 2022 •

edited

Loading

zmoon Aug 3, 2022 •

edited

Loading

zmoon Aug 3, 2022 •

edited

Loading

zmoon Aug 3, 2022 •

edited

Loading