Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only even try to import stdlib-list if we're less than py39 #78

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

ericdill
Copy link
Owner

@ericdill ericdill commented Jan 4, 2023

@mariusvniekerk ran into an issue where stdlib-list was in the environment but python was >=3.10. so he was getting the stdlib-list import attempt even though we use a different code path for 3.10. this PR fixes that by making the version checking stricter.

@ericdill ericdill requested a review from ocefpaf January 4, 2023 14:48
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Base: 92.54% // Head: 91.75% // Decreases project coverage by -0.78% ⚠️

Coverage data is based on head (c72ad2c) compared to base (e7d8463).
Patch coverage: 72.72% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   92.54%   91.75%   -0.79%     
==========================================
  Files           7        7              
  Lines         456      461       +5     
==========================================
+ Hits          422      423       +1     
- Misses         34       38       +4     
Impacted Files Coverage Δ
depfinder/stdliblist.py 69.23% <72.72%> (-30.77%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ericdill ericdill merged commit fe41c72 into main Jan 4, 2023
@ericdill ericdill deleted the firmer-stdlib-list-checking branch January 4, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants