Fix karatelabs#2324

Remove Windows filename reserved chars (<>:"/|?*)
ericdriggs · May 31, 2023 · bd607d1 · bd607d1
1 parent cac54e1
commit bd607d1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/karate-core/src/main/java/com/intuit/karate/StringUtils.java b/karate-core/src/main/java/com/intuit/karate/StringUtils.java
@@ -173,10 +173,10 @@ public static String toIdString(String name) {
         if (name == null) {
             return "";
         }
-        return name.replaceAll("[\\s_\\\\/:]", "-").toLowerCase();
+        return name.replaceAll("[\\s_\\\\/:<>\"\\|\\?\\*]", "-").toLowerCase();
     }
 
-    public static StringUtils.Pair splitByFirstLineFeed(String text) {
+public static StringUtils.Pair splitByFirstLineFeed(String text) {
         String left = "";
         String right = "";
         if (text != null) {

diff --git a/karate-core/src/test/java/com/intuit/karate/StringUtilsTest.java b/karate-core/src/test/java/com/intuit/karate/StringUtilsTest.java
@@ -96,6 +96,11 @@ void testToIdString() {
         assertEquals("foo--bar", StringUtils.toIdString("foo//bar"));
         assertEquals("foo-bar", StringUtils.toIdString("foo\\bar"));
         assertEquals("foo-bar", StringUtils.toIdString("foo:bar"));
+        assertEquals("foo-bar", StringUtils.toIdString("foo?bar"));
+        assertEquals("foo-bar", StringUtils.toIdString("foo\"bar"));
+        assertEquals("foo-bar", StringUtils.toIdString("foo*bar"));
+        assertEquals("foo-bar", StringUtils.toIdString("foo|bar"));
+        assertEquals("foo--bar", StringUtils.toIdString("foo<>bar"));
         assertEquals("", StringUtils.toIdString(null)); // TODO
     }