Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Crosshair #723

Closed
wants to merge 1 commit into from
Closed

Added Crosshair #723

wants to merge 1 commit into from

Conversation

binoculars
Copy link
Contributor

Crosshair (or more formally, reticle)
https://en.wikipedia.org/wiki/Reticle. Put it in plugins, because it
seems like an appropriate spot for it.

Made this for my pet project. It would be nice to get it in the main repo.

screen shot 2013-12-14 at 8 11 17 am
screen shot 2013-12-14 at 8 12 00 am

Crosshair (or more formally, reticle)
https://en.wikipedia.org/wiki/Reticle. Put it in plugins, because it
seems like an appropriate spot for it.
@ericdrowell
Copy link
Owner

This is awesome! However, this is more appropriate as a 3rd party plugin. KineticJS is made up of:

  1. core shapes
  2. KineticJS managed plugins
  3. 3rd party plugins

A cross hair would fit much better as a 3rd party plugin. Would it be possible for you to create a github repo for this, and I can link to it from KineticJS? I will be putting together a plugin gallery soon.

Thanks!

@binoculars
Copy link
Contributor Author

Definitely. I started https://github.com/binoculars/KineticJS-plugins

I tried to keep it in line with the structure of your main repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants