Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for defaultProps deprecated warning #791

Closed
MattFanto opened this issue May 13, 2023 · 3 comments
Closed

Support for defaultProps deprecated warning #791

MattFanto opened this issue May 13, 2023 · 3 comments

Comments

@MattFanto
Copy link

MattFanto commented May 13, 2023

Support for defaultProps deprecated warning.

Warning: Overlay: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.
    at Overlay (webpack-internal:///(app-client)/./node_modules/react-bootstrap-typeahead/es/components/Overlay/Overlay.js:52:31)
    at div
    at RootClose (webpack-internal:///(app-client)/./node_modules/react-bootstrap-typeahead/es/components/RootClose/RootClose.js:9:23)
    at TypeaheadManager (webpack-internal:///(app-client)/./node_modules/react-bootstrap-typeahead/es/core/TypeaheadManager.js:21:24)
    at Typeahead (webpack-internal:///(app-client)/./node_modules/react-bootstrap-typeahead/es/core/Typeahead.js:238:86)

It would be possible to fix this in https://github.com/ericgio/react-bootstrap-typeahead/blob/main/src/components/Overlay/Overlay.tsx#L67 please?

Version

6.1.2

Steps to reproduce

Expected Behavior

No warning should be raised

Actual Behavior

A warning is raised

@ericgio
Copy link
Owner

ericgio commented Jun 11, 2023

Fixed in v6.2.3

@ericgio ericgio closed this as completed Jun 11, 2023
@fabriziosta
Copy link

Hello, the same warning applies also for Highlighter, TypeaheadMenu, Menu

@Harshita-mindfire
Copy link

+1 to reopen this issue. I get warnings for TypeaheadMenu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants