Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultProps for functional components are deprecated #794

Merged
merged 2 commits into from
Jun 11, 2023

Conversation

mmomtchev
Copy link
Contributor

What issue does this pull request resolve?
#791

What changes did you make?
This is a cheap solution that does not improve the performance (it is a non-issue for Overlay), but removes the warning without changing the overall design or the unit testing

Is there anything that requires more attention while reviewing?
No

@ericgio ericgio merged commit cdccec4 into ericgio:main Jun 11, 2023
@ericgio
Copy link
Owner

ericgio commented Jun 11, 2023

Thanks @mmomtchev!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants