Remove default props error message / warning #824
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(ericgio#823)[ericgio#823] What changes did you make? This is a cheap solution that does not improve the performance (it is a non-issue for ClearButton), but removes the warning without changing the overall design or the unit testing Is there anything that requires more attention while reviewing? No
HarrisonHemstreet
changed the title
|
Thanks for the PR @HarrisonHemstreet! Addressed in v6.3.0 for all functional components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
#823
What changes did you make?
This is a cheap solution that does not improve the performance (it is a non-issue for ClearButton), but removes the warning without changing the overall design or the unit testing
Is there anything that requires more attention while reviewing?
No