Feature/netsupport #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 22, 2021 15:57
Only minimal set of plugins, only to version when we doesn't get any error.
In example: In metrics file's we have: "file": "src/vcsparser.core/DailyCodeChurnProcessor.cs" In `Sonar scanner CLI` we can find in `context.fileSystem()` file with exact `inputFile.filename()`. In `Sonar scanner for Net` we find entry with: inputFile.filename() = DailyCodeChurnProcessor.cs inputFile.uri() = file:///C:/Repositories/SQ/vcsparser/src/vcsparser.core/DailyCodeChurnProcessor.cs So in case of `Net` we need to match file name from metric to uri. We are doing this always when straightforward matching fail.
So it runs only once. In sonar we have project, and project can have modules. If `Sensor` is not global it will run on every module. Important for `Sonar Scanner for Net` where every `csproj` is a module. Because we are applying metrics from one file, taken for one repository, it make sense to mark this plugin global.
tomek-anuszkiewicz
force-pushed
the
feature/netsupport
branch
from
46caf42 to
31dceb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read commits descriptions.