Globals immortal objects flags #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /* The GC bit-shifts refcounts left by two, and after that shift we still | ||
| * need this to be >> 0, so leave three high zero bits (the sign bit and | ||
| * room for a shift of two.) */ | ||
| #define _PyObject_IMMORTAL_BIT (1LL << (8 * sizeof(Py_ssize_t) - 4)) |
There was a problem hiding this comment.
Use a higher bit on 32-bit builds?
There was a problem hiding this comment.
Probably not, due to the bits used by GC.
|
FYI, only one test fails: "test_negative_refcount (test.test_capi.CAPITest)" |
ericsnowcurrently
force-pushed
the
globals-immortal-objects-flags
branch
from
5f91c94 to
a80c213
Compare
|
I've created a PR upstream: python#24828. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a branch I started in December, before I found python#19474. My approach wasn't actually terribly different from what Eddie proposed. After finding that PR I updated this one a little bit, borrowing some of the details there.
Notable differences from Eddie's PR:
_Py_INCREF()Note that I haven't looked at this code for a while. There are probably a number of tweaks to make before posting this upstream.
(An alternative approach, albeit probably not ultimately viable, involves sticking a dummy type in
ob_type: python/cpython@master...ericsnowcurrently:globals-immortal-objects-obtype)