-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement EIP-7685 and EIP-6110 #10238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yperbasis
reviewed
May 8, 2024
yperbasis
reviewed
May 8, 2024
yperbasis
reviewed
May 13, 2024
@@ -506,7 +506,7 @@ func TestWithdrawalsEncoding(t *testing.T) { | |||
Amount: 5_000_000_000, | |||
} | |||
|
|||
block := NewBlock(&header, nil, nil, nil, withdrawals) | |||
block := NewBlock(&header, nil, nil, nil, withdrawals, nil /*requests*/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to add a similar TestRequestsEncoding
yperbasis
approved these changes
May 14, 2024
yperbasis
changed the title
[WIP] Implement EIP-7685 and EIP-6110
Implement EIP-7685 and EIP-6110
May 14, 2024
yperbasis
added a commit
that referenced
this pull request
May 21, 2024
Add some [EIP-7685](https://eips.ethereum.org/EIPS/eip-7685) bits missed by PR #10238
yperbasis
added a commit
that referenced
this pull request
Oct 1, 2024
Cherry pick #10238 Co-authored-by: racytech <[email protected]>
AskAlexSharov
pushed a commit
that referenced
this pull request
Oct 21, 2024
Cherry pick #10238 Co-authored-by: racytech <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All PRs from #10167 which was closed due to failing
Test erigon as a library
in integration tests