Add support for build for linux/amd64 (v1) [binaries/docker] #12003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelemodolo
approved these changes
Sep 16, 2024
yperbasis
reviewed
Sep 16, 2024
.goreleaser.yml
Outdated
| @@ -607,6 +607,211 @@ builds: | |||
| ## End of Linux AMD64 | |||
|
|
|||
|
|
|||
| ## Linux AMD64-v2: | |||
There was a problem hiding this comment.
Is it possible to parametrize the logic on v1, v2 so that we avoid the copy-paste?
There was a problem hiding this comment.
Good idea 👍
I am going to play with templates.
There was a problem hiding this comment.
Goreleaser configuration block for amd64 and amd64/v2 is now the same template for both -- which makes it simply to manage in the future.
Please, review changes, @yperbasis .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
After that change there will be multi-platform docker image with 3 OS/Arch:
as well as a new release artifact.