Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stage_bor_heimdall commits partial progress #12097

Merged
merged 3 commits into from
Nov 3, 2024
Merged

stage_bor_heimdall commits partial progress #12097

merged 3 commits into from
Nov 3, 2024

Conversation

stevemilk
Copy link
Contributor

@stevemilk stevemilk commented Sep 26, 2024 •
edited
Loading

after this PR, stage_bor_heimdall doesn't run in 1 transaction, thus can commit partial progress

@stevemilk stevemilk mentioned this pull request Sep 26, 2024
Closed
@stevemilk stevemilk marked this pull request as ready for review September 27, 2024 02:27
@AskAlexSharov
Copy link
Collaborator

hi. write a bit what is done by this PR (if it's preparation PR - "no functional changes" - it's also good).
and need merge main

@stevemilk
Copy link
Contributor Author

description added. but not sure if the PR is to the point in terms of #11904. willing to make subsequent updates if get some comments, thank you.

@AskAlexSharov AskAlexSharov enabled auto-merge (squash) November 1, 2024 04:26
@AskAlexSharov
Copy link
Collaborator

yes. it's required 1st step. merging it. but BorHeimdallForward also need update - commit every N blocks.

@stevemilk
Copy link
Contributor Author

find several commits of main branch also fail Integration tests / tests (macos-14) with same error log as this one:
https://github.com/erigontech/erigon/actions/runs/11623893941/job/32371652431
https://github.com/erigontech/erigon/actions/runs/11605442455/job/32315851495

is this a known issue?

@AskAlexSharov
Copy link
Collaborator

Yes. Merge “main” to fix

auto-merge was automatically disabled November 3, 2024 03:22

Head branch was pushed to by a user without write access

@AskAlexSharov AskAlexSharov merged commit e46cc43 into erigontech:main Nov 3, 2024
10 checks passed
@stevemilk
Copy link
Contributor Author

all checks passed, can merge now.

@stevemilk stevemilk mentioned this pull request Nov 12, 2024
Merged
taratorio pushed a commit that referenced this pull request Nov 19, 2024
@stevemilk
commit every N blocks in BorHeimdallForward (#12706)
439f28b 
step2 of #11094. 
step1:  #12097
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AskAlexSharov AskAlexSharov AskAlexSharov approved these changes

Assignees
No one assigned
Labels
polygon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevemilk @AskAlexSharov @yperbasis