commitment: clarify update kind based on afterMap
#13348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonis19
reviewed
Jan 9, 2025
antonis19
reviewed
Jan 9, 2025
antonis19
reviewed
Jan 9, 2025
antonis19
reviewed
Jan 10, 2025
antonis19
reviewed
Jan 10, 2025
antonis19
reviewed
Jan 10, 2025
antonis19
reviewed
Jan 10, 2025
| @@ -1682,7 +1719,7 @@ func (hph *HexPatriciaHashed) fold() (err error) { | |||
| } | |||
|
|
|||
| // Calculate total length of all hashes | |||
| totalBranchLen := 17 - partsCount // For every empty cell, one byte | |||
| totalBranchLen := 17 - nibblesLeftAfterUpdate // For every empty cell, one byte | |||
There was a problem hiding this comment.
Shouldn't totalBranchLen be renamed to emptyCellsInBranchLen ?
There was a problem hiding this comment.
this is branch len, counting not only amount of empty cells, but we initialize it with that value. Later we add to this len 33 bytes for each existing cell (so 0xa0[roothash]).
There was a problem hiding this comment.
so rename is incorrect and not needed
There was a problem hiding this comment.
How is the rename incorrect when it is counting the number of 1's in the afterMap bitmap ? 17 - number of 1's == number of 0s , right?
There was a problem hiding this comment.
just read code block till the end and you can see that this variable is not just count of empty cells.
AskAlexSharov
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13235