Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eth_gasPrice in RPCDaemon #2484

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Fix eth_gasPrice in RPCDaemon #2484

merged 2 commits into from
Aug 3, 2021

Conversation

canepat
Copy link
Member

@canepat canepat commented Aug 2, 2021

Avoid decreasing gasFeeCap at each GetEffectiveGasTip call
Add baseFee if any to suggested gas price (changed in SuggestPrice function because seems easier there)
Fixes #2483

Add baseFee if any to suggested gas price
@canepat canepat requested a review from AskAlexSharov August 2, 2021 22:50
@canepat canepat marked this pull request as draft August 2, 2021 23:21
@AskAlexSharov AskAlexSharov marked this pull request as ready for review August 3, 2021 02:39
Copy link
Collaborator

@AskAlexSharov AskAlexSharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@AskAlexSharov AskAlexSharov merged commit 38a31ce into devel Aug 3, 2021
@AskAlexSharov AskAlexSharov deleted the fix_issue#2483 branch August 3, 2021 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPCDaemon gives different eth_gasPrice results compared to Infura/Silkrpc
2 participants