Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added serenity consensus engine #2893

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Added serenity consensus engine #2893

merged 2 commits into from
Nov 1, 2021

Conversation

Giulio2002
Copy link
Contributor

This PR just introduces the checks that Serenity does from the execution layer side. This is not the whole "merger"

@Giulio2002
Copy link
Contributor Author

Giulio2002 commented Oct 30, 2021

not sure why one check failed, seems like it just decided to stop testing the code from point blank

@Giulio2002 Giulio2002 marked this pull request as draft October 30, 2021 22:38
@Giulio2002
Copy link
Contributor Author

Just tell me what you think, i need to add more to this

@Giulio2002
Copy link
Contributor Author

Actually, on second thought, I don't know if we need this, i will close and in case reopen

@Giulio2002 Giulio2002 closed this Oct 30, 2021
@AskAlexSharov
Copy link
Collaborator

all good

@Giulio2002
Copy link
Contributor Author

Giulio2002 commented Oct 31, 2021

actually, we need this @AskAlexSharov

@Giulio2002 Giulio2002 reopened this Oct 31, 2021
@Giulio2002 Giulio2002 marked this pull request as ready for review October 31, 2021 16:01
@Giulio2002
Copy link
Contributor Author

mind if i merge?

@AskAlexSharov AskAlexSharov merged commit e3585d7 into devel Nov 1, 2021
@AskAlexSharov AskAlexSharov deleted the beacon branch November 1, 2021 02:40
@yperbasis yperbasis mentioned this pull request Dec 8, 2021
12 tasks
@VBulikov VBulikov mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants