Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled proposer by default #3319

Merged
merged 5 commits into from
Jan 21, 2022
Merged

Enabled proposer by default #3319

merged 5 commits into from
Jan 21, 2022

Conversation

enriavil1
Copy link
Contributor

This pull request changes the --proposer flag to be on by default and adds a flag to disable proposing

Copy link
Member

@yperbasis yperbasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but let's not call

ethBackendRPC.StartProposer()

if chainConfig.TerminalTotalDifficulty is nil
(Otherwise for chains without TTD there'll be by default a wasteful proposer goroutine that does nothing.)

@yperbasis yperbasis mentioned this pull request Jan 21, 2022
12 tasks
@enriavil1 enriavil1 marked this pull request as ready for review January 21, 2022 11:25
@enriavil1 enriavil1 merged commit ffedd6a into devel Jan 21, 2022
@enriavil1 enriavil1 deleted the enabled-proposer-by-default branch January 21, 2022 19:50
@VBulikov VBulikov mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants