Get block by time stamp #3514
Merged
Get block by time stamp #3514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also add a test (can you |
|
From an accounting point of view you definitely want the block before the time stamp. If I ask for January 1, I want the block exactly then or before. You want transactions that were fully completed in the period. |
|
Do we wanna use blocksLRU for this blocks? |
|
@enriavil1 hi. Is it possible to use sort.Search here? |
@AskAlexSharov I believe sort.Search should work identically to the one I had written. |
enriavil1
added a commit
that referenced
this pull request
Feb 24, 2022
* initial * binary search through blocks * snapshot * returning highest block * oldest block is now 0 * multiple test written for getBlockByTimeStamp * retrieved picked block time stamp * added into erigon_api * returning pointer * reverting c37b99b * deleted print * proper rpc block response * fixing test * returning lowest block * lint * typo * fixed test * returning lowest-1 * skip while loop for times too big or small * added to readme * using sort.Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.